Add Github Actions workflow to build and publish Docker images #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinholters
force-pushed
the
mh/gha
branch
2 times, most recently
from
71c1221
to
f6c63e6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds docker images and publishes them at ghcr.io/pvtom/rscp2mqtt (see ghcr.io/martinholters/rscp2mqtt where I've tested this at). Images both with and without InfluxDB support are build. Pushes to the main branch are tagged
mainandmain-with-influxdb, repectively. Similar for tags, i.e. git tagv3.2will be tagged asv3.2andv3.2-with-influxdb, but they are also tagged withlatestandlatest-with-influxdb.Pull requests also have the images built (to verify they at least build fine), but they are not pushed to the registry. Would it be preferred to also push them for easier testing?
The option of running via docker should probably by mentioned in the README, but before promising anything there, I'd like to see this actually working.
@pvtom, if you have Github actions enabled in the project setting - which I think is the default - you should be able to approve the run here and have images built (but not pushed as said).